From 9e0e2f8e77f2a749045eb797133597f9bf3b312b Mon Sep 17 00:00:00 2001
From: Bradley Schofield <bradley@appwrite.io>
Date: Mon, 5 Sep 2022 11:21:04 +0100
Subject: [PATCH] Add Tests

+ Added Tests
+ Remove unneeded rand variable
---
 app/controllers/api/avatars.php            |   2 -
 tests/e2e/Services/Avatars/AvatarsBase.php |  50 ++++++++++-----------
 tests/resources/initials.png               | Bin 0 -> 3112 bytes
 3 files changed, 24 insertions(+), 28 deletions(-)
 create mode 100644 tests/resources/initials.png

diff --git a/app/controllers/api/avatars.php b/app/controllers/api/avatars.php
index afda28b86..2a2c73e3e 100644
--- a/app/controllers/api/avatars.php
+++ b/app/controllers/api/avatars.php
@@ -368,8 +368,6 @@ App::get('/v1/avatars/initials')
             ['background' => '#CBB1FC'] // Purple
         ];
 
-        $rand = \rand(0, \count($themes) - 1);
-
         $name = (!empty($name)) ? $name : $user->getAttribute('name', $user->getAttribute('email', ''));
         $words = \explode(' ', \strtoupper($name));
         // if there is no space, try to split by `_` underscore
diff --git a/tests/e2e/Services/Avatars/AvatarsBase.php b/tests/e2e/Services/Avatars/AvatarsBase.php
index e631fd439..e2ddc1a86 100644
--- a/tests/e2e/Services/Avatars/AvatarsBase.php
+++ b/tests/e2e/Services/Avatars/AvatarsBase.php
@@ -491,7 +491,6 @@ trait AvatarsBase
             'name' => 'W W',
             'width' => 200,
             'height' => 200,
-            'color' => 'ffffff',
             'background' => '000000',
         ]);
 
@@ -508,34 +507,33 @@ trait AvatarsBase
             'name' => 'W W',
             'width' => 200000,
             'height' => 200,
-            'color' => 'ffffff',
             'background' => '000000',
         ]);
 
         $this->assertEquals(400, $response['headers']['status-code']);
-
-        $response = $this->client->call(Client::METHOD_GET, '/avatars/initials', [
-            'x-appwrite-project' => $this->getProject()['$id'],
-        ], [
-            'name' => 'W W',
-            'width' => 200,
-            'height' => 200,
-            'color' => 'white',
-            'background' => '000000',
-        ]);
-
-        $this->assertEquals(400, $response['headers']['status-code']);
-
-        $response = $this->client->call(Client::METHOD_GET, '/avatars/initials', [
-            'x-appwrite-project' => $this->getProject()['$id'],
-        ], [
-            'name' => 'W W',
-            'width' => 200,
-            'height' => 200,
-            'color' => 'ffffff',
-            'background' => 'black',
-        ]);
-
-        $this->assertEquals(400, $response['headers']['status-code']);
+    }
+
+    public function testInitialImage()
+    {
+        $response = $this->client->call(Client::METHOD_GET, '/avatars/initials', [
+            'x-appwrite-project' => $this->getProject()['$id'],
+        ], [
+            'name' => 'W W',
+            'width' => 200,
+            'height' => 200,
+        ]);
+
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals('image/png', $response['headers']['content-type']);
+        $this->assertNotEmpty($response['body']);
+
+        $image = new \Imagick();
+        $image->readImageBlob($response['body']);
+        $original = new \Imagick(__DIR__ . '/../../../resources/initials.png');
+
+        $this->assertEquals($image->getImageWidth(), $original->getImageWidth());
+        $this->assertEquals($image->getImageHeight(), $original->getImageHeight());
+        $this->assertEquals('PNG', $image->getImageFormat());
+        $this->assertEquals(strlen(\file_get_contents(__DIR__ . '/../../../resources/initials.png')), strlen($response['body']));
     }
 }
diff --git a/tests/resources/initials.png b/tests/resources/initials.png
new file mode 100644
index 0000000000000000000000000000000000000000..08a61594c612009d6c7cb0b805a27676e5762815
GIT binary patch
literal 3112
zcmeHI`!~~%8-FvlvCV|i<bEmAqRDM?nR{-{H7TKO<kk`^xqQZEF6A=B2Q4*xB3p#`
zM3Ks6QHm5rqgt+Iv`_BU*XMlxh41&5@A;hbdY<Pzuk$>wbDrls=R8?>4=04Qk~9DS
zh{MkIUR#m(w?RQ$zAXJDcPmJQ;oNZm(2xh)43XT*)d|jC?f{Um8vs($0APKKN|^xw
ziXi~Z1p@%K1OODzvf4Zk0f6``yqk~1FZRH{_;&;UKO6Y<YZ9jVeCzIoab6zYKm_VU
zPyKN1$JC1oKWDkG4%vC>ozIo{hAcR3<I*%TScCYn20O!+o9>Ln?<r3d7&AjnZ>)k}
z+&mxz9p`QPymDL7L#I23n5Vt_dDXEAXR%LOWzubKUwk{#E}!~S-YlW7BIQ}pzMY#H
zW9P)bemJbL-Bz8G70h3Tgi%^Gt>GJ!aSNI6ozx6WN>0xCTzlldUK(QPph94vNAq!A
ztiKAsODW&oB|{6S-aoH8(+quUfuS~D2uf;y=otM**Xmu&Z+_Q@itjvm9XPP#Wu<w4
z_R{?;lCiSbd!D~vdT`KNl&;j!Qa2u-OkOm)b@pj*k=7Bnt<l9!xjNY|8s8K80089K
zVSAiU{JXDL*RJPK6nYIji^ph6u8-lGjRx|CdWjl61yu@C1hV~e<{!2?{my$27vr6M
z6vBga(LO_(;S=*~ie;sV!WEWqC9z|LuU1|^5P5Q1^eTB^jkR%+e_>&K<Iu!(YyJ(E
z?l-D1B?StNm4cf7*HL7|l-`E#)?P4T8hAbZ%E?X+16ONlfzR#O?-zqS+SO5eCdin`
zQAKz-Il=`|hmvw*mrq1pW=+f7N{ur9Wc&iP^eaE0CZQvCSsblh+0w6gn;u1x_kD<p
zVJ6fhu#KuZcF48zK1ZemBK~0=YsyMLmqd@-Bg5yUTX&Y0IsC&<#jm>ce$h#AtSZ*8
zlEgIoY-wZ(^IbjLiwG^v+vLJO8MZi-pT{qk<pbe)bKjMlRGu+&@78;V37)36jbuyk
zNHu&$`PVW+`U#I+_cdJiuZJye)wYToW9qcS?q5aat9lOkD;`UzXd8i3xUXT9gu<rp
zT-nvruhWp2^~v-XaLFM>N}Xm{eT&^Xv*$P7pqgn?s4i2iCKh3geL0W`ugDG*b>f{i
zIu=XWHsH#)8pB`knneFSkK@r8_z2d@XflZioeOk&maA^7IU?VaUqhwyzm<ron^y33
z6A#Yse%+4BuFPVV&t&z?pz~0`IoMoIvlE%IaBpcY<hUkL+{{Syy|@<++@jgejaACC
zEy5cU%t*B)R(g3@+n}f<b>J<T9-69xu`?zk9aCd(l2}=`p{4Fr6jUHH-2O@#z0a$C
zIiAq69Rsm+H*K0V0Hwy+zjvIP348~WFnE7LpQvg!ZD4ryCq|a{UYFQto`8Hn5+Z1f
z$rHq#O;dK{hGxi5%wpS{<d-cT>%ybAAucWJ^w_MBuFDX4v@8|1Q-C{-G~z3`ihMYf
zr=fRkqW2rw7FWui^6fhg28T1&->&Ooi~K#?0=Xu!IZfoa<zeC<h>vIxeV?rca<-D=
zL-^@Jpk^BgGuTb<rWSu^-~M4Gp6>MBbEZpX@a2aILRo_$2&*L}OGYU{vB!^9=2*$(
zG&e|dTP)e;BkZF|Dv}@d?LZgh;O6r&1kgdHuD$NQY?0#^dl=)YlDB#X<{<Mhlp=Yi
z^U;*|QeWuVh>V7Ad_68EzW-%?UX&Qjs?h(AZ_&|i*ZB~0$Bk20VJ{XBN^MC(E`s-I
z;ag3w{HYUh_R1X<^9%P*l7%QN6#F`9M^SHW1b@gLF);Y;JWXUCPYWE@t9=MpA)3-0
zDqnCu!fH*xEKui~rcWSjp&XMPnK^TAP}P@<xIUKXdw^5Aw?jhoDx};D^jB#}iUNI>
z<U0=PP7Y=;XlOiF=FN}&veqatPtLHt;u6FsT0UW-a%G*9rGy3aDn{(vNjueNu=u*Y
z9XBIZB|z5#xbDL(xUUq&jB2<DYY|W$uXQp4q|@tC7m%JP&n27VHi;$bWIB2Yw<L3g
z-|crV^h&8&aeAKWrU%l)DP8KD>ZnYY>mtGg*Q6>j&-N!h+U+}gVg|fa5JG!^EL1sF
zbQ<ZqX46!0<k{-Psv&$&tIfimCvA$K?LO;Y`f<RT_B4;8znO2Hwf*I^=e)N1Nz6Vb
zDfp0=pP4jcs;#*;f|wNGXXASRx(;Y5KO{9trYDBP=#EIt3AruthE9_7ueWSD;H;^J
z+5ruS(6iV#bI>iC8saa?<M>@3`uhE>j;Nog{I{sCve=bC?gWG#RLZaS<pj;{ZW|3k
z>t*J_H+q`N`bv+k*QMRhy2L#)OrAVeT@+RB+-S`=ijs}{urgNgyfC8QisF!A+3#xd
z(EB*5x_}<fyMt4DELg!AQZBtKBMD_$aXTRKmeqFWWYkb5&I)zZ=HZ1zi>Qoee$Q#A
z@5pl#>4I-e+&Js4*F|b4r%<vB4V`ghe3^6_UDcD!%z%qmsg#V}aCIAI#Kg_>q~Zui
zaz!1cRFs6XN!sQn?9gtq8|`vEhyHr*0A+3H0$8k|h%^4M0{QTf506~i&XMhzs*;eh
zrnjY{-fV_;R;wiIk7<l%#VnqUbzv?V>B{;ae=l9%DI`Jz)Y2k7&8byjDNDLIPO;sq
zqt8-m{`xKR$1iT!H0F-cdp!m<c4ac3;vyL3IKIGoT$MFF%6@OpD_2J_uHk6P%@8N7
z?IP*jy_<3F5bZB;IYFihrf2)mNaJ~_A<t2iw)0QF*gK{31GAF``U2ryo5uq;s8H_-
zW#tcjof&m8z8<ixE+s*lx!G{L-5x|Fe^?#OVBzSSgmidZMz#rejQ*FxIWVH&`Yq(L
zOQYRJ4)Z21LE8Mu5}^UN9?a0z(9cnGi8~^%Er3IKw#kdZjVeRGB1Pw`U~*^DL4u%Y
z!w%jw-r~81RbVdDsPC;%wm(%O?dty&eFz>^!^NOUSrHk%_2hxW4j%S(w!yUj09WC4
A&j0`b

literal 0
HcmV?d00001