From 7567f1632db1246115306dc43e593031d2b9ec15 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pedro=20Gon=C3=A7alves?= Date: Tue, 1 Oct 2019 15:19:51 +0100 Subject: [PATCH 1/3] Fixed some countries translation (PT-PT) There were some countries that were in PT-BR, fixed :smile: --- app/config/locale/pt-pt.countries.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/config/locale/pt-pt.countries.php b/app/config/locale/pt-pt.countries.php index 9b628e867..c3ceca51d 100644 --- a/app/config/locale/pt-pt.countries.php +++ b/app/config/locale/pt-pt.countries.php @@ -7,7 +7,7 @@ return [ 'AD' => 'Andorra', 'AE' => 'Emirados Árabes Unidos', 'AR' => 'Argentina', - 'AM' => 'Armênia', + 'AM' => 'Arménia', 'AG' => 'Antígua e Barbuda', 'AU' => 'Austrália', 'AT' => 'Áustria', @@ -55,7 +55,7 @@ return [ 'EG' => 'Egito', 'ER' => 'Eritreia', 'ES' => 'Espanha', - 'EE' => 'Estônia', + 'EE' => 'Estónia', 'ET' => 'Etiópia', 'FI' => 'Finlândia', 'FJ' => 'Fiji', @@ -106,15 +106,15 @@ return [ 'LS' => 'Lesoto', 'LT' => 'Lituânia', 'LU' => 'Luxemburgo', - 'LV' => 'Letônia', + 'LV' => 'Letónia', 'MA' => 'Marrocos', - 'MC' => 'Mônaco', + 'MC' => 'Mónaco', 'MD' => 'Moldávia', 'MG' => 'Madagáscar', 'MV' => 'Maldivas', 'MX' => 'México', 'MH' => 'Ilhas Marshall', - 'MK' => 'Macedônia', + 'MK' => 'Macedónia', 'ML' => 'Mali', 'MT' => 'Malta', 'MM' => 'Myanmar', @@ -141,7 +141,7 @@ return [ 'PH' => 'Filipinas', 'PW' => 'Palau', 'PG' => 'Papua-Nova Guiné', - 'PL' => 'Polônia', + 'PL' => 'Polónia', 'KP' => 'Coreia do Norte', 'PT' => 'Portugal', 'PY' => 'Paraguai', From 067aa41015eab7412305276672b179f3b2fc2a35 Mon Sep 17 00:00:00 2001 From: Antero Santos <36671793+SantosAntero@users.noreply.github.com> Date: Tue, 1 Oct 2019 15:25:14 +0100 Subject: [PATCH 2/3] Fixed some countries translations --- app/config/locale/pt-pt.countries.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/config/locale/pt-pt.countries.php b/app/config/locale/pt-pt.countries.php index 9b628e867..2f30dc6d8 100644 --- a/app/config/locale/pt-pt.countries.php +++ b/app/config/locale/pt-pt.countries.php @@ -89,7 +89,7 @@ return [ 'JO' => 'Jordânia', 'JP' => 'Japão', 'KZ' => 'Cazaquistão', - 'KE' => 'Quênia', + 'KE' => 'Quénia', 'KG' => 'Quirguistão', 'KH' => 'Camboja', 'KI' => 'Quiribati', @@ -163,7 +163,7 @@ return [ 'ST' => 'São Tomé e Príncipe', 'SR' => 'Suriname', 'SK' => 'Eslováquia', - 'SI' => 'Eslovênia', + 'SI' => 'Eslovénia', 'SE' => 'Suécia', 'SZ' => 'Suazilândia', 'SC' => 'Seicheles', @@ -188,10 +188,10 @@ return [ 'VA' => 'Cidade do Vaticano', 'VC' => 'São Vincente e Granadinas', 'VE' => 'Venezuela', - 'VN' => 'Vietnã', + 'VN' => 'Vietname', 'VU' => 'Vanuatu', 'WS' => 'Samoa', - 'YE' => 'Iêmen', + 'YE' => 'Iémen', 'ZA' => 'África do Sul', 'ZM' => 'Zâmbia', 'ZW' => 'Zimbábue', From 410f7e66cce4b4566e477d30092594e51530b478 Mon Sep 17 00:00:00 2001 From: Bharat Raghunathan Date: Tue, 1 Oct 2019 20:44:09 +0530 Subject: [PATCH 3/3] Fix typos and grammar in AddOAuthProvider.md --- docs/AddOAuthProvider.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/AddOAuthProvider.md b/docs/AddOAuthProvider.md index 290f2a91d..b5a04da2e 100644 --- a/docs/AddOAuthProvider.md +++ b/docs/AddOAuthProvider.md @@ -6,13 +6,13 @@ This document is part of the Appwrite contributors' guide. Before you continue r ### Agenda -OAuth providers help users to log in easily to apps and websites without the need to provide passwords or any other type of credentials. Appwrite goal is to have support to as many **major** OAuth providers as possible. +OAuth providers help users to log in easily to apps and websites without the need to provide passwords or any other type of credentials. Appwrite goal is to have support from as many **major** OAuth providers as possible. -As of the writing of these lines, we do not accept any minor OAuth providers. For us to accept smaller and potentially unlimited number of providers some product design and software architecture changes must be applied first. +As of the writing of these lines, we do not accept any minor OAuth providers. For us to accept some smaller and potentially unlimited number of OAuth providers, some product design and software architecture changes must be applied first. ### List Your new Provider -The first step in adding a new OAuth provider is to list it in providers config file array, located at: +The first step to follow in adding a new OAuth provider is to add it to the list in providers config file array, located at: ``` ./app/config/providers.php @@ -22,11 +22,11 @@ Make sure to fill all data needed and that your provider array key name is in ca ### Add Provider Logo -Add a logo image to your new provider in this path: ./public/images/oauth. Your logo should be a png 100×100px file with the name of your provider (all lowercase). Please make sure to leave about 20px padding around the logo to be consistent with other logos. +Add a logo image to your new provider in this path: `./public/images/oauth`. Your logo should be a png 100×100px file with the name of your provider (all lowercase). Please make sure to leave about 20px padding around the logo to be consistent with other logos. ### Add Provider Class -Once finished setting all the metadata for the new provider you need to start coding. +Once you have finished setting up all the metadata for the new provider, you need to start coding. Create a new class that extends the basic OAuth provider abstract class in this location: @@ -36,14 +36,14 @@ src/Auth/OAuth/ProviderName Note that the class name should start with a capital letter as PHP FIG standards suggest. -Once created a new class you can start to implement your new provider login flow. The best way to do this right is to have a look at another provider implementation and try to follow the same standards. +Once a new class is created, you can start to implement your new provider's login flow. The best way to do this right is to have a look at another provider's implementation and try to follow the same standards. -Please mention in your documentation what resources or API docs you used to implement the provider OAuth protocol. +Please mention in your documentation what resources or API docs you used to implement the provider's OAuth protocol. ### Test Your Provider -After you finished adding your new provider to Appwrite you should be able to see it in your Appwrite console. Navigate to 'Project>Users>Providers' and check your new provider's settings form. +After you finished adding your new provider to Appwrite you should be able to see it in your Appwrite console. Navigate to 'Project > Users > Providers' and check your new provider's settings form. -Add credentials and check both a successful and a failed login (where user reject integration on provider page). +Add credentials and check both a successful and a failed login (where the user rejects integration on provider page). -If everything goes well, just send us the pull request and be responsive if any feedback arise during our code review. \ No newline at end of file +If everything goes well, just send us the pull request and be ready to respond to any feedback which can arise during our code review.