From 1d6d43baf8981ea824d8b50114063305b38dc0f4 Mon Sep 17 00:00:00 2001
From: Christy Jacob <christyjacob4@gmail.com>
Date: Tue, 15 Feb 2022 19:59:26 +0400
Subject: [PATCH] feat: fix issues with delete endpoint

---
 app/executor.php | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/app/executor.php b/app/executor.php
index 389fe150fa..8b9d3abc24 100644
--- a/app/executor.php
+++ b/app/executor.php
@@ -33,16 +33,15 @@ use Utopia\Validator\Text;
 // Remove orphans on startup - done
 // Remove multiple request attempt to the runtime logic in executor - done
 // Remove builds param from delete endpoint - done
+// Shutdown callback isn't working as expected - done
 
-
-// Shutdown callback isn't working as expected
 // Incorporate Matej's changes in the build stage ( moving of the tar file will be performed by the runtime and not the build stage )
 // Fix error handling and logging
 // Fix delete endpoint
 // Add size validators for the runtime IDs 
 // Decide on logic for build and runtime containers names ( runtime-ID and build-ID)
 
-Runtime::enableCoroutine(SWOOLE_HOOK_ALL);
+Runtime::enableCoroutine(true, SWOOLE_HOOK_ALL);
 
 /** Constants */
 const MAINTENANCE_INTERVAL = 1200; // 20 minutes
@@ -769,7 +768,7 @@ $http->on('start', function ($http) {
 });
 
 
-$http->on('shutdown', function() {
+$http->on('beforeShutdown', function() {
     global $orchestrationPool;
     Console::info('Cleaning up containers before shutdown...');
 
@@ -777,7 +776,6 @@ $http->on('shutdown', function() {
     $functionsToRemove = $orchestration->list(['label' => 'openruntimes-type=function']);
     $orchestrationPool->put($orchestration);
 
-    // This does not seem to be working since this is not a coroutine scope . 
     foreach ($functionsToRemove as $container) {
         go(function () use ($orchestrationPool, $container) { 
             try {