From 078b5360d3a8ff1ec2cdfbd21189090324ab38cc Mon Sep 17 00:00:00 2001 From: Torsten Dittmann Date: Fri, 5 Feb 2021 12:18:12 +0100 Subject: [PATCH] adds traversal check to deleteion --- app/workers/deletes.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/workers/deletes.php b/app/workers/deletes.php index a329afe24..426dcf1ed 100644 --- a/app/workers/deletes.php +++ b/app/workers/deletes.php @@ -314,9 +314,10 @@ class DeletesV1 { $domain = $document->getAttribute('domain'); $directory = APP_STORAGE_CERTIFICATES . '/' . $domain; + $checkTraversal = realpath($directory) === $directory; - if($domain && is_dir($directory)) { - array_map('unlink', glob("$directory/*.*")); + if($domain && $checkTraversal && is_dir($directory)) { + array_map('unlink', glob($directory.'/*.*')); rmdir($directory); Console::info("Deleted certificate files for {$domain}"); } else {