CodeMirror/SystemTrayMenu
1
0
Fork 0
mirror of https://github.com/Hofknecht/SystemTrayMenu.git synced 2024-07-06 06:51:04 +12:00
Code Issues Projects Releases Wiki Activity

Log spam protection on COM exceptions while reading icons

Browse source
This commit is contained in:
Peter Kirmeier 2023-09-11 17:50:10 +02:00
parent 2f790b3226
commit 4f1ee5385c
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Utilities/File/IconReader.cs
View file

@ -27,6 +27,8 @@ namespace SystemTrayMenu.Utilities
private static readonly ConcurrentDictionary<string, BitmapSource> IconDictCache = new();
private static readonly BitmapSource? OverlayImage = (BitmapSource?)Application.Current.Resources["LinkArrowIconImage"];
private static int maxCOMExceptionLogs = 5;
// see https://github.com/Hofknecht/SystemTrayMenu/issues/209.
internal static bool IsPreloading { get; set; } = true;
@ -203,7 +205,12 @@ namespace SystemTrayMenu.Utilities
catch (COMException ex)
{
// This seems to happen very rarely, so we just log it and go on
Log.Warn("Reading native Icon failed:", ex);
// However, we protect this log message from being called often, so we stop logging after a while
if (maxCOMExceptionLogs > 0)
{
maxCOMExceptionLogs--; // Note: written by multiple threads, but it is not worth any protection
Log.Warn("Reading native Icon failed:", ex);
}
}
icon?.Dispose();