Rename UploadData method to SendRequestFile for consistency with other methods

This commit is contained in:
Jaex 2016-12-26 19:47:46 +03:00
parent d3a075ffec
commit 8161d1440a
53 changed files with 54 additions and 57 deletions

View file

@ -121,10 +121,7 @@ public virtual void StopUpload()
protected string SendRequest(HttpMethod method, string url, Dictionary<string, string> args = null, NameValueCollection headers = null,
CookieCollection cookies = null, ResponseType responseType = ResponseType.Text)
{
using (HttpWebResponse response = GetResponse(method, url, null, null, args, headers, cookies))
{
return ResponseToString(response, responseType);
}
return SendRequest(method, url, (Stream)null, null, args, headers, cookies, responseType);
}
protected string SendRequest(HttpMethod method, string url, Stream data, string contentType = null, Dictionary<string, string> args = null, NameValueCollection headers = null,
@ -204,7 +201,7 @@ protected string SendRequestMultiPart(string url, Dictionary<string, string> arg
}
}
protected UploadResult UploadData(string url, Stream data, string fileName, string fileFormName = "file", Dictionary<string, string> args = null,
protected UploadResult SendRequestFile(string url, Stream data, string fileName, string fileFormName = "file", Dictionary<string, string> args = null,
NameValueCollection headers = null, CookieCollection cookies = null, ResponseType responseType = ResponseType.Text, HttpMethod method = HttpMethod.POST,
string contentType = ContentTypeMultipartFormData, string metadata = null)
{

View file

@ -220,7 +220,7 @@ public override UploadResult Upload(Stream stream, string fileName)
Dictionary<string, string> args = new Dictionary<string, string>();
args.Add("parent_id", FolderID);
UploadResult result = UploadData("https://upload.box.com/api/2.0/files/content", stream, fileName, "filename", args, GetAuthHeaders());
UploadResult result = SendRequestFile("https://upload.box.com/api/2.0/files/content", stream, fileName, "filename", args, GetAuthHeaders());
if (result.IsSuccess)
{

View file

@ -144,7 +144,7 @@ public UploadResult UploadFile(Stream stream, string path, string fileName)
string query = OAuthManager.GenerateQuery(url, args, HttpMethod.POST, AuthInfo);
// There's a 1GB and 5 hour(max time for a single upload) limit to all uploads through the API.
UploadResult result = UploadData(query, stream, fileName, "file", headers: APIHeaders);
UploadResult result = SendRequestFile(query, stream, fileName, "file", headers: APIHeaders);
if (result.IsSuccess)
{

View file

@ -85,7 +85,7 @@ public override UploadResult Upload(Stream stream, string fileName)
throw new Exception("'Request type' must be 'POST' when using custom file uploader.");
}
UploadResult result = UploadData(customUploader.GetRequestURL(), stream, fileName, customUploader.GetFileFormName(), customUploader.GetArguments(),
UploadResult result = SendRequestFile(customUploader.GetRequestURL(), stream, fileName, customUploader.GetFileFormName(), customUploader.GetArguments(),
customUploader.GetHeaders(), responseType: customUploader.ResponseType);
if (result.IsSuccess)

View file

@ -70,7 +70,7 @@ public override UploadResult Upload(Stream stream, string fileName)
args.Add("token", drop.AdminToken);
args.Add("drop_name", drop.Name);
UploadResult result = UploadData("http://assets.drop.io/upload", stream, fileName, "file", args);
UploadResult result = SendRequestFile("http://assets.drop.io/upload", stream, fileName, "file", args);
if (result.IsSuccess)
{

View file

@ -44,7 +44,7 @@ public sealed class Dropfile : FileUploader
{
public override UploadResult Upload(Stream stream, string fileName)
{
UploadResult result = UploadData("https://d1.dropfile.to/upload", stream, fileName);
UploadResult result = SendRequestFile("https://d1.dropfile.to/upload", stream, fileName);
if (result.IsSuccess)
{

View file

@ -35,7 +35,7 @@ public override UploadResult Upload(Stream stream, string fileName)
Dictionary<string, string> args = new Dictionary<string, string>();
args.Add("MAX_FILE_SIZE", "82428800");
UploadResult result = UploadData("http://filebin.ca/upload.php", stream, fileName, "file", args);
UploadResult result = SendRequestFile("http://filebin.ca/upload.php", stream, fileName, "file", args);
if (result.IsSuccess)
{

View file

@ -52,7 +52,7 @@ public override UploadResult Upload(Stream stream, string fileName)
if (!string.IsNullOrEmpty(url))
{
result = UploadData(url, stream, fileName);
result = SendRequestFile(url, stream, fileName);
if (!string.IsNullOrEmpty(result.Response))
{

View file

@ -116,7 +116,7 @@ public override UploadResult Upload(Stream stream, string fileName)
if (file != null)
{
result = UploadData(file.Upload.PostURL, stream, fileName);
result = SendRequestFile(file.Upload.PostURL, stream, fileName);
if (result.IsSuccess)
{

View file

@ -68,7 +68,7 @@ public override UploadResult Upload(Stream stream, string fileName)
args.Add("signature", "mk9t/U/wRN4/uU01mXfeTe2Kcoc=");
args.Add("Content-Type", Helpers.GetMimeType(fileName));
UploadResult result = UploadData("https://gifaffe.s3.amazonaws.com/", stream, fileName, "file", args);
UploadResult result = SendRequestFile("https://gifaffe.s3.amazonaws.com/", stream, fileName, "file", args);
if (!result.IsError)
{

View file

@ -260,7 +260,7 @@ public override UploadResult Upload(Stream stream, string fileName)
string metadata = GetMetadata(fileName, FolderID);
UploadResult result = UploadData("https://www.googleapis.com/upload/drive/v2/files?uploadType=multipart", stream, fileName, headers: GetAuthHeaders(),
UploadResult result = SendRequestFile("https://www.googleapis.com/upload/drive/v2/files?uploadType=multipart", stream, fileName, headers: GetAuthHeaders(),
contentType: "multipart/related", metadata: metadata);
if (!string.IsNullOrEmpty(result.Response))

View file

@ -73,7 +73,7 @@ public override UploadResult Upload(Stream stream, string fileName)
if (!string.IsNullOrEmpty(Email) && !string.IsNullOrEmpty(Password))
{
NameValueCollection headers = CreateAuthenticationHeader(Email, Password);
result = UploadData("https://api.hostr.co/file", stream, fileName, headers: headers);
result = SendRequestFile("https://api.hostr.co/file", stream, fileName, headers: headers);
if (result.IsSuccess)
{

View file

@ -233,7 +233,7 @@ public override UploadResult Upload(Stream stream, string fileName)
NameValueCollection headers = new NameValueCollection();
headers.Set("X-Atlassian-Token", "nocheck");
UploadResult res = UploadData(query, stream, fileName, headers: headers);
UploadResult res = SendRequestFile(query, stream, fileName, headers: headers);
if (res.Response.Contains("errorMessages"))
{
Errors.Add(res.Response);

View file

@ -70,7 +70,7 @@ public override UploadResult Upload(Stream stream, string fileName)
{
Dictionary<string, string> arguments = new Dictionary<string, string>();
arguments.Add("api_key", Config.UserAPIKey);
UploadResult result = UploadData(uploadUrl, stream, fileName, "file", arguments, method: HttpMethod.PUT);
UploadResult result = SendRequestFile(uploadUrl, stream, fileName, "file", arguments, method: HttpMethod.PUT);
if (result.Response == null)
{

View file

@ -68,7 +68,7 @@ public override UploadResult Upload(Stream stream, string fileName)
{
Dictionary<string, string> arguments = new Dictionary<string, string>();
arguments.Add("key", Config.UserAPIKey);
UploadResult result = UploadData(uploadUrl, stream, fileName, "file", arguments);
UploadResult result = SendRequestFile(uploadUrl, stream, fileName, "file", arguments);
if (result.IsSuccess)
{

View file

@ -66,7 +66,7 @@ public override UploadResult Upload(Stream stream, string fileName)
try
{
result = UploadData(URLHelpers.CombineURL(APIURL, "api/upload/file"), stream, fileName);
result = SendRequestFile(URLHelpers.CombineURL(APIURL, "api/upload/file"), stream, fileName);
}
catch (WebException e)
{

View file

@ -121,7 +121,7 @@ private string SimpleUpload(Stream stream, string fileName)
args.Add("response_format", "json");
args.Add("signature", GetSignature("upload/simple.php", args));
string url = CreateQuery(_apiUrl + "upload/simple.php", args);
UploadResult res = UploadData(url, stream, fileName, "Filedata");
UploadResult res = SendRequestFile(url, stream, fileName, "Filedata");
if (!res.IsSuccess) throw new IOException(res.ErrorsToString());
SimpleUploadResponse resp = DeserializeResponse<SimpleUploadResponse>(res.Response);
EnsureSuccess(resp);

View file

@ -246,7 +246,7 @@ public override UploadResult Upload(Stream stream, string fileName)
args.Add("caption", fileName);
args.Add("filename", fileName);
UploadResult result = UploadData(url, stream, fileName, "file", args);
UploadResult result = SendRequestFile(url, stream, fileName, "file", args);
if (result.IsSuccess)
{

View file

@ -183,7 +183,7 @@ public override UploadResult Upload(Stream stream, string fileName)
string url = CreateQuery(URLHelpers.CombineURL("https://apis.live.net/v5.0", folderPath), args);
UploadResult result = UploadData(url, stream, fileName);
UploadResult result = SendRequestFile(url, stream, fileName);
if (result.IsSuccess)
{

View file

@ -99,7 +99,7 @@ public Pomf(PomfUploader uploader)
public override UploadResult Upload(Stream stream, string fileName)
{
UploadResult result = UploadData(Uploader.UploadURL, stream, fileName, "files[]");
UploadResult result = SendRequestFile(Uploader.UploadURL, stream, fileName, "files[]");
if (result.IsSuccess)
{

View file

@ -101,7 +101,7 @@ public UploadResult PushFile(Stream stream, string fileName)
upArgs.Add("policy", fileInfo.data.policy);
upArgs.Add("content-type", fileInfo.data.content_type);
UploadResult uploadResult = UploadData(fileInfo.upload_url, stream, fileName, "file", upArgs);
UploadResult uploadResult = SendRequestFile(fileInfo.upload_url, stream, fileName, "file", upArgs);
if (uploadResult == null) return null;

View file

@ -104,7 +104,7 @@ public override UploadResult Upload(Stream stream, string fileName)
arguments.Add("k", APIKey);
arguments.Add("z", "ShareX");
UploadResult result = UploadData(PuushAPIUploadURL, stream, fileName, "f", arguments);
UploadResult result = SendRequestFile(PuushAPIUploadURL, stream, fileName, "f", arguments);
if (result.IsSuccess)
{

View file

@ -73,7 +73,7 @@ public override UploadResult Upload(Stream stream, string fileName)
args.Add("folder", FolderID);
}
UploadResult result = UploadData(url, stream, fileName, "filecontent", args);
UploadResult result = SendRequestFile(url, stream, fileName, "filecontent", args);
if (result.IsSuccess)
{

View file

@ -442,7 +442,7 @@ public override UploadResult Upload(Stream stream, string fileName)
args.Add("filename", fileName);
args.Add("parent_dir", Path);
UploadResult result = UploadData(responseURL, stream, fileName, "file", args, headers);
UploadResult result = SendRequestFile(responseURL, stream, fileName, "file", args, headers);
if (!IsError)
{

View file

@ -507,7 +507,7 @@ public UploadResult Upload(Stream stream, string fileName, UploadInfo uploadInfo
{
Dictionary<string, string> args = PrepareArguments(uploadInfo.MaxFileSize, uploadInfo.UploadIdentifier, uploadInfo.ExtraInfo);
result = UploadData(uploadInfo.URL, stream, fileName, "userfile", args);
result = SendRequestFile(uploadInfo.URL, stream, fileName, "userfile", args);
if (result.IsSuccess)
{

View file

@ -32,7 +32,7 @@ public sealed class ShareCX : FileUploader
{
public override UploadResult Upload(Stream stream, string fileName)
{
UploadResult result = UploadData("http://file1.share.cx/cgi-bin/upload.cgi", stream, fileName, "file_0");
UploadResult result = SendRequestFile("http://file1.share.cx/cgi-bin/upload.cgi", stream, fileName, "file_0");
if (result.IsSuccess)
{

View file

@ -85,7 +85,7 @@ public override UploadResult Upload(Stream stream, string fileName)
headers = CreateAuthenticationHeader(Email, Password);
}
UploadResult result = UploadData(URLHelpers.CombineURL(Host, "upload"), stream, fileName, headers: headers);
UploadResult result = SendRequestFile(URLHelpers.CombineURL(Host, "upload"), stream, fileName, headers: headers);
TranscodeFile(result);

View file

@ -73,7 +73,7 @@ public override UploadResult Upload(Stream stream, string fileName)
string url = "https://s-ul.eu";
url = URLHelpers.CombineURL(url, "upload.php");
UploadResult result = UploadData(url, stream, fileName, "file", args);
UploadResult result = SendRequestFile(url, stream, fileName, "file", args);
if (result.IsSuccess)
{

View file

@ -43,7 +43,7 @@ public sealed class Transfersh : FileUploader
{
public override UploadResult Upload(Stream stream, string fileName)
{
UploadResult result = UploadData("https://transfer.sh", stream, fileName);
UploadResult result = SendRequestFile("https://transfer.sh", stream, fileName);
if (result.IsSuccess)
{

View file

@ -58,7 +58,7 @@ public override UploadResult Upload(Stream stream, string fileName)
arguments.Add("name", CustomName);
}
UploadResult result = UploadData("https://uguu.se/api.php?d=upload-tool", stream, fileName, "file", arguments);
UploadResult result = SendRequestFile("https://uguu.se/api.php?d=upload-tool", stream, fileName, "file", arguments);
if (result.IsSuccess)
{

View file

@ -125,7 +125,7 @@ public override UploadResult Upload(Stream stream, string fileName)
args.Add("token", upleaBestNode.Token);
args.Add("file_id[]", Guid.NewGuid().ToString());
UploadResult result = UploadData(string.Format("http://{0}/", upleaBestNode.Name), stream, fileName, "files[]", args);
UploadResult result = SendRequestFile(string.Format("http://{0}/", upleaBestNode.Name), stream, fileName, "files[]", args);
UpleaGetUpleaUploadResponse uploadResult = JsonConvert.DeserializeObject<UpleaGetUpleaUploadResponse>(result.Response);
if (uploadResult.Files.Length > 0)

View file

@ -51,7 +51,7 @@ public override UploadResult Upload(Stream stream, string fileName)
Dictionary<string, string> arguments = new Dictionary<string, string>();
arguments.Add("api", "1");
UploadResult result = UploadData(URLUpload, stream, fileName, "videoFile", arguments);
UploadResult result = SendRequestFile(URLUpload, stream, fileName, "videoFile", arguments);
result.URL = result.Response;

View file

@ -118,7 +118,7 @@ public override UploadResult Upload(Stream stream, string fileName)
string url = URLHelpers.FixPrefix(Uploader.UploadURL);
UploadResult result = UploadData(url, stream, fileName, "source", args);
UploadResult result = SendRequestFile(url, stream, fileName, "source", args);
if (result.IsSuccess)
{

View file

@ -82,7 +82,7 @@ public override UploadResult Upload(Stream stream, string fileName)
throw new Exception("'Request type' must be 'POST' when using custom image uploader.");
}
UploadResult result = UploadData(customUploader.GetRequestURL(), stream, fileName, customUploader.GetFileFormName(), customUploader.GetArguments(),
UploadResult result = SendRequestFile(customUploader.GetRequestURL(), stream, fileName, customUploader.GetFileFormName(), customUploader.GetArguments(),
customUploader.GetHeaders(), responseType: customUploader.ResponseType);
if (result.IsSuccess)

View file

@ -261,7 +261,7 @@ public override UploadResult Upload(Stream stream, string fileName)
args.Add("api_sig", GetAPISig(args));
UploadResult result = UploadData("https://up.flickr.com/services/upload/", stream, fileName, "photo", args);
UploadResult result = SendRequestFile("https://up.flickr.com/services/upload/", stream, fileName, "photo", args);
if (result.IsSuccess)
{

View file

@ -42,7 +42,7 @@ public override UploadResult Upload(Stream stream, string fileName)
arguments.Add("sfile", "Upload");
arguments.Add("url", "");
UploadResult result = UploadData("http://imagebin.ca/upload.php", stream, fileName, "f", arguments);
UploadResult result = SendRequestFile("http://imagebin.ca/upload.php", stream, fileName, "f", arguments);
if (result.IsSuccess)
{

View file

@ -100,7 +100,7 @@ public override UploadResult Upload(Stream stream, string fileName)
arguments.Add("auth_token", Config.Auth_token);
arguments.Add("public", Config.IsPublic ? "y" : "n");
UploadResult result = UploadData(URLUpload, stream, fileName, "file", arguments);
UploadResult result = SendRequestFile(URLUpload, stream, fileName, "file", arguments);
if (!string.IsNullOrEmpty(result.Response))
{

View file

@ -33,7 +33,7 @@ public sealed class Img1Uploader : ImageUploader
public override UploadResult Upload(Stream stream, string fileName)
{
UploadResult result = UploadData(uploadURL, stream, fileName, "fileup");
UploadResult result = SendRequestFile(uploadURL, stream, fileName, "fileup");
if (result.IsSuccess)
{

View file

@ -51,7 +51,7 @@ public override UploadResult Upload(Stream stream, string fileName)
Dictionary<string, string> arguments = new Dictionary<string, string>();
arguments.Add("usubmit", "true");
UploadResult result = UploadData(uploadUrl, stream, fileName, "imagefile[]", arguments);
UploadResult result = SendRequestFile(uploadUrl, stream, fileName, "imagefile[]", arguments);
if (result.IsSuccess)
{

View file

@ -250,7 +250,7 @@ private UploadResult InternalUpload(Stream stream, string fileName, bool refresh
}
WebExceptionReturnResponse = true;
UploadResult result = UploadData("https://api.imgur.com/3/image", stream, fileName, "image", args, headers);
UploadResult result = SendRequestFile("https://api.imgur.com/3/image", stream, fileName, "image", args, headers);
if (!string.IsNullOrEmpty(result.Response))
{

View file

@ -32,7 +32,7 @@ public sealed class ImmioUploader : ImageUploader
{
public override UploadResult Upload(Stream stream, string fileName)
{
UploadResult result = UploadData("http://imm.io/store/", stream, fileName, "image");
UploadResult result = SendRequestFile("http://imm.io/store/", stream, fileName, "image");
if (result.IsSuccess)
{
ImmioResponse response = JsonConvert.DeserializeObject<ImmioResponse>(result.Response);

View file

@ -124,7 +124,7 @@ public UploadResult UploadMedia(Stream stream, string fileName, string albumID)
string query = OAuthManager.GenerateQuery(url, args, HttpMethod.POST, AuthInfo);
query = FixURL(query);
UploadResult result = UploadData(query, stream, fileName, "uploadfile");
UploadResult result = SendRequestFile(query, stream, fileName, "uploadfile");
if (result.IsSuccess)
{

View file

@ -80,7 +80,7 @@ public override UploadResult Upload(Stream stream, string fileName)
arguments.Add("type", "binary");
arguments.Add("shared", "false");
UploadResult result = UploadData("https://api.sli.mg/media", stream, fileName, "data", arguments, GetAuthHeaders());
UploadResult result = SendRequestFile("https://api.sli.mg/media", stream, fileName, "data", arguments, GetAuthHeaders());
if (result.IsSuccess)
{

View file

@ -79,7 +79,7 @@ public override UploadResult Upload(Stream stream, string fileName)
arguments.Add("apikey", API_KEY);
arguments.Add("familysafe", "0"); // Set to 0 as images could possibly not be family safe.
UploadResult result = UploadData(API_ENDPOINT, stream, fileName, "file", arguments);
UploadResult result = SendRequestFile(API_ENDPOINT, stream, fileName, "file", arguments);
if (result.IsSuccess)
{

View file

@ -99,7 +99,7 @@ public override UploadResult Upload(Stream stream, string fileName)
arguments.Add("type", "image");
arguments.Add("tags", "");
result = UploadData(URLAPI, stream, fileName, "uploadfile", arguments);
result = SendRequestFile(URLAPI, stream, fileName, "uploadfile", arguments);
if (result.IsSuccess && CheckResponse(result.Response))
{

View file

@ -100,7 +100,7 @@ private UploadResult Upload(Stream stream, string fileName, string url, string m
args.Add("oauth_secret", AuthInfo.UserSecret);
args.Add("message", msg);
UploadResult result = UploadData(url, stream, fileName, "media", args);
UploadResult result = SendRequestFile(url, stream, fileName, "media", args);
TwitPicResponse response = JsonConvert.DeserializeObject<TwitPicResponse>(result.Response);

View file

@ -67,7 +67,7 @@ private UploadResult Upload(Stream stream, string fileName, string msg)
args.Add("message", msg);
}
UploadResult result = UploadData(APIURL, stream, fileName, "media", args);
UploadResult result = SendRequestFile(APIURL, stream, fileName, "media", args);
return ParseResult(result);
}

View file

@ -146,7 +146,7 @@ public UploadResult TweetMessageWithMedia(string message, Stream stream, string
Dictionary<string, string> args = new Dictionary<string, string>();
args.Add("status", message);
UploadResult result = UploadData(query, stream, fileName, "media[]", args);
UploadResult result = SendRequestFile(query, stream, fileName, "media[]", args);
if (!string.IsNullOrEmpty(result.Response))
{

View file

@ -46,7 +46,7 @@ public override UploadResult Upload(Stream stream, string fileName)
arguments.Add("xmlOutput", "1");
//arguments.Add("testMode", "1");
UploadResult result = UploadData("http://img1.uploadscreenshot.com/api-upload.php", stream, fileName, "userfile", arguments);
UploadResult result = SendRequestFile("http://img1.uploadscreenshot.com/api-upload.php", stream, fileName, "userfile", arguments);
return ParseResult(result);
}

View file

@ -60,7 +60,7 @@ public override UploadResult Upload(Stream stream, string fileName)
Dictionary<string, string> args = new Dictionary<string, string>();
if (!string.IsNullOrEmpty(UserKey)) args.Add("userkey", UserKey);
UploadResult result = UploadData("https://vgy.me/upload", stream, fileName, "file", args);
UploadResult result = SendRequestFile("https://vgy.me/upload", stream, fileName, "file", args);
if (result.IsSuccess)
{

View file

@ -119,7 +119,7 @@ private UploadResult Upload(Stream stream, string fileName, string msg)
arguments.Add("key", Options.DeveloperKey);
UploadResult result = UploadData(url, stream, fileName, "media", arguments);
UploadResult result = SendRequestFile(url, stream, fileName, "media", arguments);
return ParseResult(result);
}

View file

@ -100,7 +100,7 @@ public OCRSpaceResponse DoOCR(Stream stream, string fileName)
arguments.Add("language", Language.ToString());
arguments.Add("isOverlayRequired", Overlay.ToString());
UploadResult ur = UploadData(APIURLUSA, stream, fileName, "file", arguments);
UploadResult ur = SendRequestFile(APIURLUSA, stream, fileName, "file", arguments);
if (ur.IsSuccess)
{

View file

@ -101,7 +101,7 @@ public override UploadResult UploadText(string text, string fileName)
byte[] byteArray = Encoding.UTF8.GetBytes(text);
using (MemoryStream stream = new MemoryStream(byteArray))
{
result = UploadData(requestURL, stream, fileName, customUploader.GetFileFormName(), args, customUploader.GetHeaders(), responseType: customUploader.ResponseType);
result = SendRequestFile(requestURL, stream, fileName, customUploader.GetFileFormName(), args, customUploader.GetHeaders(), responseType: customUploader.ResponseType);
}
}
}