From 4c0ea0e1f300a30c8d25d799e812fe49e5c2f525 Mon Sep 17 00:00:00 2001 From: Matthew Burnett Date: Thu, 24 Jan 2019 17:59:17 -0500 Subject: [PATCH] Use least priviledge scope GCS Remove debug write --- ShareX.UploadersLib/FileUploaders/GoogleCloudStorage.cs | 2 +- .../URLShorteners/FirebaseDynamicLinksURLShortener.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ShareX.UploadersLib/FileUploaders/GoogleCloudStorage.cs b/ShareX.UploadersLib/FileUploaders/GoogleCloudStorage.cs index 5ff967d32..2a864fb69 100644 --- a/ShareX.UploadersLib/FileUploaders/GoogleCloudStorage.cs +++ b/ShareX.UploadersLib/FileUploaders/GoogleCloudStorage.cs @@ -78,7 +78,7 @@ public GoogleCloudStorage(OAuth2Info oauth) { googleAuth = new GoogleOAuth2(oauth, this) { - Scope = "https://www.googleapis.com/auth/devstorage.full_control" + Scope = "https://www.googleapis.com/auth/devstorage.read_write" }; } diff --git a/ShareX.UploadersLib/URLShorteners/FirebaseDynamicLinksURLShortener.cs b/ShareX.UploadersLib/URLShorteners/FirebaseDynamicLinksURLShortener.cs index b6de8795e..99033020c 100644 --- a/ShareX.UploadersLib/URLShorteners/FirebaseDynamicLinksURLShortener.cs +++ b/ShareX.UploadersLib/URLShorteners/FirebaseDynamicLinksURLShortener.cs @@ -116,7 +116,7 @@ public override UploadResult ShortenURL(string url) string requestjson = JsonConvert.SerializeObject(request); result.Response = SendRequest(HttpMethod.POST, "https://firebasedynamiclinks.googleapis.com/v1/shortLinks", requestjson, UploadHelpers.ContentTypeJSON, args); - DebugHelper.WriteLine(result.Response); + FirebaseResponse firebaseResponse = JsonConvert.DeserializeObject(result.Response); if (firebaseResponse != null)