From a218ceb4e814729ca39eebdb8f1c6af9d833628b Mon Sep 17 00:00:00 2001 From: Nick Sweeting Date: Tue, 18 Aug 2020 04:52:56 -0400 Subject: [PATCH] add test for overwrite flag --- tests/test_args.py | 48 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/tests/test_args.py b/tests/test_args.py index c616cb80..4ca659ed 100644 --- a/tests/test_args.py +++ b/tests/test_args.py @@ -8,26 +8,58 @@ def test_depth_flag_is_accepted(process, disable_extractors_dict): capture_output=True, env=disable_extractors_dict) assert 'unrecognized arguments: --depth' not in arg_process.stderr.decode("utf-8") + def test_depth_flag_fails_if_it_is_not_0_or_1(process, disable_extractors_dict): - arg_process = subprocess.run(["archivebox", "add", "http://127.0.0.1:8080/static/example.com.html", "--depth=5"], - capture_output=True, env=disable_extractors_dict) + arg_process = subprocess.run( + ["archivebox", "add", "--depth=5", "http://127.0.0.1:8080/static/example.com.html"], + capture_output=True, + env=disable_extractors_dict, + ) assert 'invalid choice' in arg_process.stderr.decode("utf-8") - arg_process = subprocess.run(["archivebox", "add", "http://127.0.0.1:8080/static/example.com.html", "--depth=-1"], - capture_output=True, env=disable_extractors_dict) + arg_process = subprocess.run( + ["archivebox", "add", "--depth=-1", "http://127.0.0.1:8080/static/example.com.html"], + capture_output=True, + env=disable_extractors_dict, + ) assert 'invalid choice' in arg_process.stderr.decode("utf-8") + def test_depth_flag_0_crawls_only_the_arg_page(tmp_path, process, disable_extractors_dict): - arg_process = subprocess.run(["archivebox", "add", "http://127.0.0.1:8080/static/example.com.html", "--depth=0"], - capture_output=True, env=disable_extractors_dict) + arg_process = subprocess.run( + ["archivebox", "add", "--depth=0", "http://127.0.0.1:8080/static/example.com.html"], + capture_output=True, + env=disable_extractors_dict, + ) + archived_item_path = list(tmp_path.glob('archive/**/*'))[0] with open(archived_item_path / "index.json", "r") as f: output_json = json.load(f) assert output_json["base_url"] == "127.0.0.1:8080/static/example.com.html" + def test_depth_flag_1_crawls_the_page_AND_links(tmp_path, process, disable_extractors_dict): - arg_process = subprocess.run(["archivebox", "add", "http://127.0.0.1:8080/static/example.com.html", "--depth=1"], - capture_output=True, env=disable_extractors_dict) + arg_process = subprocess.run( + ["archivebox", "add", "--depth=1", "http://127.0.0.1:8080/static/example.com.html"], + capture_output=True, + env=disable_extractors_dict, + ) + with open(tmp_path / "index.json", "r") as f: archive_file = f.read() assert "http://127.0.0.1:8080/static/example.com.html" in archive_file assert "http://127.0.0.1:8080/static/iana.org.html" in archive_file + + +def test_overwrite_flag_is_accepted(process, disable_extractors_dict): + subprocess.run( + ["archivebox", "add", "--depth=0", "http://127.0.0.1:8080/static/example.com.html"], + capture_output=True, + env=disable_extractors_dict, + ) + arg_process = subprocess.run( + ["archivebox", "add", "--overwrite", "http://127.0.0.1:8080/static/example.com.html"], + capture_output=True, + env=disable_extractors_dict, + ) + assert 'unrecognized arguments: --overwrite' not in arg_process.stderr.decode("utf-8") + assert 'favicon' in arg_process.stdout.decode('utf-8'), 'archive methods probably didnt run, did overwrite work?'