1
0
Fork 0
mirror of synced 2024-06-17 01:44:30 +12:00

Merge pull request #1123 from fa0311/dev

This commit is contained in:
Nick Sweeting 2023-03-18 08:07:23 -06:00 committed by GitHub
commit 829e377890
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -219,7 +219,7 @@ def get_headers(url: str, timeout: int=None) -> str:
def chrome_args(**options) -> List[str]:
"""helper to build up a chrome shell command with arguments"""
from .config import CHROME_OPTIONS
from .config import CHROME_OPTIONS, CHROME_VERSION
options = {**CHROME_OPTIONS, **options}
@ -229,7 +229,10 @@ def chrome_args(**options) -> List[str]:
cmd_args = [options['CHROME_BINARY']]
if options['CHROME_HEADLESS']:
cmd_args += ('--headless',)
if int(CHROME_VERSION.split()[1].split('.')[0]) >= 111:
cmd_args += ("--headless=new",)
else:
cmd_args += ('--headless',)
if not options['CHROME_SANDBOX']:
# assume this means we are running inside a docker container