From 76846d18a06f745038a4f185bc532dbe8ce069d0 Mon Sep 17 00:00:00 2001 From: Cristian Date: Mon, 10 Aug 2020 09:00:10 -0500 Subject: [PATCH] docs: Improve message for missing singlefile binary --- archivebox/config/__init__.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/archivebox/config/__init__.py b/archivebox/config/__init__.py index 98d01068..9bdea244 100644 --- a/archivebox/config/__init__.py +++ b/archivebox/config/__init__.py @@ -778,9 +778,16 @@ def check_system_config(config: ConfigDict=CONFIG) -> None: stderr(' CHROME_USER_DATA_DIR="{}"'.format(config['CHROME_USER_DATA_DIR'].split('/Default')[0])) raise SystemExit(2) +def dependency_additional_info(dependency: str) -> str: + if dependency == "SINGLEFILE_BINARY": + return "Please follow the installation instructions at https://github.com/gildas-lormeau/SingleFile/tree/master/cli and set SINGLEFILE_BINARY or set USE_SINGLEFILE=false" + return "" + + def check_dependencies(config: ConfigDict=CONFIG, show_help: bool=True) -> None: invalid = [ - '{}: {} ({})'.format(name, info['path'] or 'unable to find binary', info['version'] or 'unable to detect version') + '{}: {} ({}). {}'.format(name, info['path'] or 'unable to find binary', info['version'] or 'unable to detect version', + dependency_additional_info(name)) for name, info in config['DEPENDENCIES'].items() if info['enabled'] and not info['is_valid'] ]